Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore 3ds2 tests. #9455

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Ignore 3ds2 tests. #9455

merged 1 commit into from
Oct 16, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

These fail because of a recent refactor on the backend.

@github-actions GitHub Actions
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │   0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │   0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │   0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ +10 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ +10 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20252 │ 20252 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29463 │ 29463 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK 
    compressed    │  uncompressed   │                                           
──────────┬───────┼──────────┬──────┤                                           
 size     │ diff  │ size     │ diff │ path                                      
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 28.3 KiB │  +9 B │ 62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │  +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 28.6 KiB │ +10 B │ 62.7 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review October 16, 2024 15:25
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners October 16, 2024 15:25
@jaynewstrom-stripe
Copy link
Collaborator Author

https://stripe.slack.com/archives/CFA2HJ99A/p1729088070084689

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3613

@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) October 16, 2024 15:27
@jaynewstrom-stripe jaynewstrom-stripe merged commit 40d6017 into master Oct 16, 2024
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/ignore-3ds2 branch October 16, 2024 15:36
reuben-stripe added a commit that referenced this pull request Oct 17, 2024
@reuben-stripe
Revert "Ignore 3ds2 tests. (#9455)"
4b697f4 
This reverts commit 40d6017.
@reuben-stripe reuben-stripe mentioned this pull request Oct 17, 2024
Merged
jaynewstrom-stripe pushed a commit that referenced this pull request Oct 17, 2024
@reuben-stripe
Revert "Ignore 3ds2 tests. (#9455)" (#9466)
0b239e4 
This reverts commit 40d6017.
amk-stripe pushed a commit that referenced this pull request Oct 22, 2024
@jaynewstrom-stripe @amk-stripe
Ignore 3ds2 tests. (#9455)
7e570bf
amk-stripe pushed a commit that referenced this pull request Oct 22, 2024
@reuben-stripe @amk-stripe
Revert "Ignore 3ds2 tests. (#9455)" (#9466)
95be569 
This reverts commit 40d6017.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillh-stripe tillh-stripe tillh-stripe approved these changes

@tjclawson-stripe tjclawson-stripe Awaiting requested review from tjclawson-stripe tjclawson-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaynewstrom-stripe @tillh-stripe